This repository was archived by the owner on Oct 6, 2026. It is now read-only.
Repository navigation
add timeout for graphql requests - #588
Closed
alperenkaplan wants to merge 1 commit into
Closed
alperenkaplan wants to merge 1 commit into
alperenkaplan wants to merge 1 commit into
Conversation
ghost
added
the 
Contributor
|
Thanks for contributing! This package is deprecated and we're archiving this repo, so we're closing all open issues and PRs. Please use shopify-app-python instead, and open new issues there. More context: Rethinking support for PHP/Python packages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
I realized that shopify servers sometimes doesn't respond and the code halts. Giving an optional timeout parameter would fix the issue.
WHAT is this pull request doing?
Adding an optional timeout parameter to the execute method of GraphQL Class in shopify/resources/graphql.py on line 18 and using that parameter on line 27.
Checklist