Skip to content
This repository was archived by the owner on Oct 6, 2026. It is now read-only.

[Feature] Return dictionary and raise GraphQLException on error from GraphQL query - #774

Closed
cedk wants to merge 1 commit into
Shopify:mainfrom
cedk:graphql-json-error
Closed

cedk wants to merge 1 commit into
Shopify:mainfrom
cedk:graphql-json-error

Conversation

@cedk

@cedk cedk commented May 7, 2025

Copy link
Copy Markdown

WHY are these changes introduced?

Using the GraphQL API, the response are raw text containing the JSON.
The errors are most of the time answered with a 200 status with an errors array.

WHAT is this pull request doing?

This ease the usage of GraphQL API by ensuring proper load of the JSON response and manage errors by raising an exception.

Checklist

  • I have updated the CHANGELOG (if applicable)
  • I have followed the Shopify Python guide

@cedk

cedk commented May 7, 2025

Copy link
Copy Markdown
Author

I have signed the CLA!

@cedk
cedk force-pushed the graphql-json-error branch from d264bb7 to c7a959d Compare May 26, 2025 16:45
@Suleimanlatrsh

Copy link
Copy Markdown
Contributor

Thanks for contributing! This package is deprecated and we're archiving this repo, so we're closing all open issues and PRs. Please use shopify-app-python instead, and open new issues there. More context: Rethinking support for PHP/Python packages

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants