Repository navigation
[QC-1262] repo_cleaner instances must not share their last execution time - #2700
Merged
Barthelemy merged 1 commit intoOct 14, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last time repocleaner is ran is stored as a timestamp in a file in /tmp. The issue was that the file name was the same whatever the instance and we actually run one instance for sync and one for async in the same machine. Thus they were cross-talking.
The proposed changes make sure we have a different file for each instance. As there are different ways of launching the script we have different ways of computing the unique file name. In same cases it might not be unique but I know from the usage that it won't be an issue. What matters is the "config_consul" case.