Repository navigation
Match user extensions to their folder through the /home symlink - #14
Merged
Merged
Conversation
patches/0033-linux-symlinked-extension-paths.patch adds src/renderer/src/util/extensionPaths.ts. Vortex records the plugins folder from userData (/home/... on Fedora Atomic, where /home links to /var/home), but Node reports module filenames and stack frames with the symlink resolved (/var/home/...). The prefix checks in extensionRequire.ts and in the unhandled-error handler in renderer.tsx never matched a user-installed extension. Such an extension could not load modules bundled with Vortex (Elden Ring: "Cannot find module 'turbowalk'"), ran without the Linux fs wrapper, and an uncaught error in it closed Vortex instead of showing the extension error notice. Both checks now also compare against the folder's real path. PKGBUILD and .SRCINFO list the new patch.
Arkazzae
added a commit
that referenced
this pull request
Oct 16, 2026
extensionInStack escaped only backslashes, so a real path with parentheses, such as a folder named "Data (2TB)", reported the extension as "unknown", and an unbalanced one would throw inside the error handler. It now escapes the whole path. A root that doesn't exist yet, such as plugins/ before the first extension is installed, takes the real path of its nearest existing parent instead of caching the unresolved path for the session. matchExistingCaseSync returns early when the path already exists, like resolveCaseInsensitiveSync. CHANGELOG.md describes #14 and #15, and pkgrel moves to 4 to release them.
Owner
|
Thanks for tracking this down! Merged, with two small tweaks on top: the extension path is now fully escaped in the stack regex (a folder like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into some issues with have a symlink home dir and case sensitivity during game validation, split the commits into their PRs just in case.