Skip to content

fix(project): show fullscreen titles placed at the end of the video - #2681

Open
yashranaway wants to merge 2 commits into
CapSoftware:mainfrom
yashranaway:fix/fullscreen-closing-title
Open

yashranaway wants to merge 2 commits into
CapSoftware:mainfrom
yashranaway:fix/fullscreen-closing-title

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

a fullscreen title placed right where the video ends, like a closing card, makes the timeline longer, but there was no source frame to map that extra time to. playback and export both stop as soon as a frame has no source, so the closing title never showed up.

now a hold that starts at the very end falls back to the last source instant before the end, so the title plays over the final frame. normal end of timeline behavior is unchanged. tests cover multiple clips, speed changes, transitions and an empty timeline.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no new actionable issues were found.

Summary

Closing fullscreen titles now hold the last instant of the final non-empty clip instead of relying on a rounded timeline time.

  • Closing titles show over the final clip frame.

Reviews (2) · Last reviewed commit: "fix(project): hold the last clip instant..." · Reviewed by Greptile

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@vercel

vercel Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

Comment thread crates/project/src/configuration.rs Outdated
@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant