Repository navigation
fix(project): show fullscreen titles placed at the end of the video - #2681
Open
yashranaway wants to merge 2 commits into
Open
yashranaway wants to merge 2 commits into
yashranaway wants to merge 2 commits into
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a fullscreen title placed right where the video ends, like a closing card, makes the timeline longer, but there was no source frame to map that extra time to. playback and export both stop as soon as a frame has no source, so the closing title never showed up.
now a hold that starts at the very end falls back to the last source instant before the end, so the title plays over the final frame. normal end of timeline behavior is unchanged. tests cover multiple clips, speed changes, transitions and an empty timeline.
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no new actionable issues were found.Summary
Closing fullscreen titles now hold the last instant of the final non-empty clip instead of relying on a rounded timeline time.
Reviews (2) · Last reviewed commit: "fix(project): hold the last clip instant..." · Reviewed by Greptile