Skip to content

fix(rendering): keep late camera timestamps in the FFmpeg decoder - #2684

Merged
richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/camera-pts-late
Oct 18, 2026
Merged

richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/camera-pts-late

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

this is the camera-pts-late export case from the verify expectations. the ffmpeg decoder subtracted the stream's start time when labelling frames but seeked on the original timeline, so a camera file whose timestamps start 2s in played up to 60 frames ahead from the very first output frame. avassetreader already keeps the original timestamps.

now ffmpeg keeps them too, and the existing first frame hold covers the gap before the camera starts. the xfail is gone and the late start model sequences now run for ffmpeg too. five of those seeds hit the same grid rounding entry the zero start cases already have, so they get one.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable defects were found.

Summary

The FFmpeg decoder now preserves presentation timestamps instead of subtracting the stream’s start time.

  • FFmpeg keeps late-start video frames on their original timeline.

Reviews (2) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@vercel

vercel Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

# Conflicts:
#	crates/rendering/src/decoder/model/mod.rs
@richiemcilroy
richiemcilroy merged commit 18bc0dc into CapSoftware:main Oct 18, 2026
45 of 47 checks passed
@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants