Repository navigation
Conversation
We need it for Python 3.15 support. Otherwise, TypeError: Can't instantiate abstract class WheelDistribution without an implementation for abstract method 'locate_file'
This reverts commit 7d1e747.
(v1.8.5 is the last version that supports Python 3.8) We need it for Python 3.15 support. Otherwise, TypeError: Can't instantiate abstract class WheelDistribution without an implementation for abstract method 'locate_file'
We need it for Python 3.15 support. Otherwise, TypeError: Can't instantiate abstract class WheelDistribution without an implementation for abstract method 'locate_file'
We need it for Python 3.15 support. Otherwise, TypeError: Can't instantiate abstract class WheelDistribution without an implementation for abstract method 'locate_file'
Co-authored-by: Xmader <16057139+Xmader@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The private CPython layout changes need confirmation from successful cross-platform Python 3.15 builds and runtime tests.
0 open findings
What changed in this PR
Adds Python 3.15 compatibility to PythonMonkey’s event-loop integration and packaging, addressing the installation issue reported in #511.
Changes:
- Updates the mirrored CPython thread-state layout for Python 3.15.
- Refreshes build tooling and version-specific dependencies.
- Adds Python 3.15 to the cross-platform test and publishing matrix.
| File | Description |
|---|---|
| src/PyEventLoop.cc | Adjusts event-loop lookup for Python 3.15 internals. |
| setup.sh | Upgrades the Poetry installer version. |
| python/pminit/pyproject.toml | Updates the versioning build dependency. |
| pyproject.toml | Updates build dependencies and Python-specific pip/NumPy constraints. |
| poetry.lock | Refreshes resolved dependencies and package hashes. |
| .github/workflows/test-and-publish.yaml | Adds Python 3.15 coverage and upgrades Poetry. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will resolve issue #511