Repository navigation
[CHA-0] fix(ci): drop URI::Escape from hidden.rbi; retry blocklist spec - #222
Merged
Merged
Conversation
Ruby 3.4 no longer defines URI::Escape, so srb tc fails with 'Unable to resolve constant Escape' on the 3.4 lint job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nijeesh-stream
requested review from
JimmyPettersson85,
shaljam and
vishalnarkhede
as code owners
October 15, 2026 02:04
UpdateChannelType sometimes rejects a blocklist created a moment earlier with 'invalid block list name' on the shared CI app. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nijeesh-stream
changed the title
nijeesh-stream
enabled auto-merge (squash)
October 15, 2026 09:39
JimmyPettersson85
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
The required
💎 Ruby 3.4check fails on every PR, including docs-only ones (e.g. #220), becausebundle exec srb tccannot resolveURI::Escape. This PR deletes the oneextend ::URI::Escapeline from the generatedsorbet/rbi/hidden-definitions/hidden.rbi. Risk is negligible: only Sorbet's view ofURIchanges, no runtime code does.Ticket
Summary
hidden.rbiwas generated on an older Ruby, whereURIextendedURI::Escape. Ruby 3.4 removed that module, so the lint step (rubocop +srb tc, run on 3.4 and 4.0) reports:Because the matrix runs with
max-parallel: 1and fail-fast, the 3.4 failure also cancels the 4.0 jobs.Second fix, found while running CI on this PR:
blocklist use the blocklist for a channel typefailed on 3.0 and then on 3.4 withUpdateChannelType failed with error: "invalid block list name "<uuid>"". The blocklist is created a moment earlier, but UpdateChannelType does not always see it yet on the shared CI app. The step is now wrapped in the file's existingloop_times 10retry helper.Verified locally on Ruby 3.4.2:
srb tcreports 2 errors on master andNo errors! Great job.with this change;rake rubocoppasses.Checklist
./docs) has been updated (n/a)🤖 Generated with Claude Code