Repository navigation
Conversation
Add a "Disable ICMP Forwarding" VpnService option and pass it through to the core tun configuration. When enabled (default), ICMP echo requests are answered locally instead of being forwarded directly, avoiding ICMP leaks and the 'receive ICMP echo reply: i/o timeout' error.
Add an ICMP Timeout VpnService option and pass it through to the core tun configuration, so a custom icmp-timeout is no longer ignored. The default value 0 keeps the core default (10s).
Negative input produced a negative ICMPTimeout, which sets a past read deadline and breaks ICMP forwarding with an immediate 'i/o timeout'. Coerce the parsed value to at least zero and trim whitespace, and label the option with the seconds unit.
sudoup
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.