Repository navigation
Don't store conditionId on Change in ConditionTable.from_df - #551
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #551 +/- ##
=======================================
Coverage 77.98% 77.98%
=======================================
Files 68 68
Lines 7791 7791
Branches 1390 1390
=======================================
Hits 6076 6076
Misses 1227 1227
Partials 488 488 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
fix_condition_id_change
branch
from
October 15, 2026 10:19
a6cbaee to
bc80381
Compare
dweindl
marked this pull request as ready for review
October 15, 2026 10:24
dilpath
approved these changes
Oct 15, 2026
`ConditionTable.from_df` passed the full table rows to `Change`, so the condition ID ended up as an extra field on each `Change`. In `to_df`, this stale ID overrode the ID of the `Condition`, so renaming a condition after loading was ignored. Also, a loaded table did not compare equal to the original one. Fixes PEtab-dev#550. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
force-pushed
the
fix_condition_id_change
branch
from
October 15, 2026 11:37
bc80381 to
dd57ec9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConditionTable.from_dfpassed the full table rows toChange, so the condition ID ended up as an extra field on eachChange. Into_df, this stale ID overrode the ID of theCondition, so renaming a condition after loading was silently ignored on writing. Also, a loaded table did not compare equal to the original one.Now,
from_dfdoesn't passconditionIdtoChange, andto_dfalways uses the ID of theCondition.Fixes #550.
🤖 Generated with Claude Code