Repository navigation
fix(ui): destructive-query dialog fits small windows; long table names in DML preview are cut (#1642) - #1698
Merged
Merged
Conversation
…ng table names in DML preview are cut (#1642)
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1642.
Destructive-query dialog (
destructive_query_dialog.dart) had fixed constraints (540-680 x 440-580) and a fixed 540 px body, so on a narrow window or at a UI scale of 1.25x+ it ran off the screen. It now takes 680 x 540 at 1x, scaled with the UI scale throughWindowLayout.scaledDialogExtent, never larger than the window minusWindowLayout.dialogSymmetricInsets, and sits inside those insets. The body keeps its designed height (540 at 1x) and scrolls when the window is shorter: the new small-window test showed that only shrinking the card overflowed the content by 123 px at 520 x 420.DML preview (
dml_preview_dialog.dart): theschema.tablebadge put its text in aRowwithoutFlexible, so a long name overflowed the dialog. The text is nowFlexible, one line, with an ellipsis.Tests: the destructive dialog in a 520 x 420 window has no overflow and stays inside the window with its buttons; the DML preview with a ~170-character name renders without an overflow.