Repository navigation
fix(packaging): .deb and .rpm of a beta sort before the final release (#1494) - #1708
Merged
Merged
Conversation
… (0.5.0~beta.1) (#1494)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1494. Part of the Beta channel epic #1499.
build_deb.shwroteVersion: 0.5.0-beta.1, which dpkg reads as upstream0.5.0with revisionbeta.1, newer than0.5.0;build_rpm.shwrote0.5.0.beta.1, also newer than0.5.0. Beta users would never be upgraded to the final package.scripts/linux/package_version.shmaps the pubspec version to the package version: the first-becomes~(which both dpkg and rpm sort before anything, even the end of the string), any further-becomes.(it would otherwise start a Debian revision or an RPM release).0.5.0-beta.1→0.5.0~beta.1; a final0.5.0is unchanged.build_deb.shandbuild_rpm.shuse it forVersion:/%{version}. The file names keep the tag form (Querya-Desktop-0.5.0-beta.1-linux.deb), so the updater's asset rules andSHA256SUMS.txtare unaffected.AppVersioninquerya.issis free text and noVersionInfoVersionis derived from it, so-beta.1is accepted. macOS takes the version from Flutter's build name; whetherCFBundleShortVersionStringwith-beta.1is accepted (and notarized) needs the dry run from ci(release): beta tags publish a pre-release, not latest, and skip AUR / APT / DNF #1492.Behaviour change worth knowing: an old marketing suffix such as
0.4.11-bnow becomes0.4.11~b, which sorts before0.4.11(SemVer reading) instead of after it.Tests (
test/packaging/): the mapping; and, where the tools exist, that0.4.19 < 0.5.0-beta.1 < 0.5.0-beta.2 < 0.5.0-beta.10 < 0.5.0 < 0.5.1holds fordpkg --compare-versions(present on the Ubuntu CI runners) and forrpm.vercmp(skipped whenrpmis not installed).