Repository navigation
test(installtest): keep the fake release in step with .goreleaser.yaml - #161
Conversation
A new test reads .goreleaser.yaml. It expands each OS and architecture of the builds through the archive name template and the format overrides. Then it compares the result and the checksum file name with the names that the fake release serves. The fake release now has one list of targets, and ReleaseArchives and ChecksumsName export the names from this list. The fake release also serves a zip for each Windows target, with runware.exe at its root. checksums.txt lists a digest for each archive, and BadChecksum makes each digest incorrect. A second test downloads each archive and compares its content and its digest. The install scripts build the archive names from the OS and the architecture, and .goreleaser.yaml sets the real names. No test compared the names in the fake release with this file. Thus a change to the name template or to the checksum name stopped every install, but CI stayed green. Now such a change makes the test fail. RUNSERV-1302. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues in the focused fixture changes and regression tests; tests were not executed.
0 open findings
What changed in this PR
Adds regression checks to keep the install-test fake release aligned with GoReleaser’s release configuration.
Changes:
- Centralizes fake-release targets and exposes archive and checksum filenames.
- Adds Windows ZIP archives containing
runware.exe. - Tests configuration alignment, archive contents, and correct or deliberately invalid checksums.
| File | Description |
|---|---|
| internal/installtest/release_test.go | Verifies served archive contents and checksums. |
| internal/installtest/installtest.go | Centralizes targets and adds Windows ZIP support. |
| internal/installtest/goreleaser_test.go | Compares fake-release metadata with GoReleaser configuration. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
A new test reads .goreleaser.yaml. It expands each OS and architecture of
the builds through the archive name template and the format overrides.
Then it compares the result and the checksum file name with the names that
the fake release serves. The fake release now has one list of targets,
and ReleaseArchives and ChecksumsName export the names from this list.
The fake release also serves a zip for each Windows target, with
runware.exe at its root. checksums.txt lists a digest for each archive,
and BadChecksum makes each digest incorrect. A second test downloads each
archive and compares its content and its digest.
The install scripts build the archive names from the OS and the
architecture, and .goreleaser.yaml sets the real names. No test compared
the names in the fake release with this file. Thus a change to the name
template or to the checksum name stopped every install, but CI stayed
green. Now such a change makes the test fail. RUNSERV-1302.
Co-Authored-By: Claude Opus 5.5 (1M context) noreply@anthropic.com
🤖 Generated with Claude Code