Repository navigation
Include API actions in JSON findings - #407
Open
John-David Dalton (jdalton) wants to merge 1 commit into
Open
John-David Dalton (jdalton) wants to merge 1 commit into
John-David Dalton (jdalton) wants to merge 1 commit into
Conversation
Expose the Socket API action on selected standard JSON findings while preserving legacy Issue serialization, equality, alert selection, and process exit behavior. Verify both real SDK transport paths with the local HTTP fixture. Assisted-by: Codex:gpt-6-luna
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Description written by Codex:gpt-6-luna
Carry the Socket API's resolved action into each selected alert row in standard JSON. The new
actionfield preserves the API value and is null when unavailable; legacy Issue serialization, equality, existing alert selection, links, and CLI process exit behavior remain unchanged.Why?
JSON consumers need the action Socket resolved for a finding to present consistent remediation without changing existing CI behavior. Strict blocking continues to include unchanged error and warning findings, while standard output continues to use the existing selected rows.
Public Changelog
Standard Socket JSON now includes the API action on each selected finding.
Note
Low Risk
Additive JSON field and internal Issue metadata with explicit tests that selection, exit codes, and legacy serialization are unchanged.
Overview
Standard Socket JSON (
--enable-json) now exposes the Socket API’s resolved policy action on each selected alert row asaction(e.g.error,warn,monitor,ignore), or JSONnullwhen the API omits it or the value isn’t a string.The CLI reads
actionfrom API alert payloads intoIssue.api_actionduring diff processing, then pairs selected issues with serialized rows inbuild_socket_json_reportsoactionlines up with existing alert selection (including--strict-blockingunchanged findings).Issue.to_dict()andDiffserialization omitapi_action, so legacy equality/serialization paths stay the same;actiondoes not change exit codes or blocking flags. Docs incli-reference.mddescribe the new field.Reviewed by Cursor Bugbot for commit fe1b610. Configure here.