Repository navigation
[TS PBT] Save campaign artifacts before stdout publication - #614
Open
CaelmBleidd wants to merge 1 commit into
Open
CaelmBleidd wants to merge 1 commit into
CaelmBleidd wants to merge 1 commit into
Conversation
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
campaign-filecould lose a completed, serialized result when stdout failed or the outer deadline interrupted its output: the destination file was written afterward. Save the existing encoded JSON before appending it to stdout, so an output failure leaves a readable artifact. Afinallyblock preserves stdout fallback when the file write fails. The command retains identical file/stdout JSON and encodes it once.Closes #612. Based on #581 (
028d5b0c116502525cdb2329f24bde665807922f); only the command and its focused test change. The caller/JVM deadline-origin gap remains tracked in #613. This change does not explain or resolve every zero-stdout missing-artifact run, and a killed process remains incomplete for primary experimental credit.Validation:
NoSuchFileException.CampaignFileCliTesttests pass after the change. A failing sink reads the saved artifact before its first stdout write, then throwsIOException; the command reports the output error and retains the artifact. A separate file-write failure preserves the complete stdout artifact and the original error.:usvm-ts-fast-check:detektMain/detektTestandgit diff --checkpass.The frozen experimental assembly and measurement artifacts were not changed. No scientific pilot was rerun.