Repository navigation
fix(@angular/build): support incremental asset updates and output cleanup in library watch mode - #34340
fix(@angular/build): support incremental asset updates and output cleanup in library watch mode#34340alan-agius4 wants to merge 1 commit into
Conversation
a0c5d91 to
6a6da31
Compare
657ddba to
6d590c8
Compare
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Angular library builder to normalize all file and directory paths to POSIX format, and introduces robust watch-mode cleanup for deleted assets, manifest files, and bundle files. Feedback on these changes highlights that the rm call used for cleanup should include recursive: true so that maxRetries is not ignored, and any deletion failures should be logged as warnings rather than silently ignored.
13b80df to
78c5a6a
Compare
alan-agius4
added
action: cleanup
c126333 to
638cdb6
Compare
alan-agius4
added
action: review
…anup in library watch mode Ensure the library builder properly handles created, modified, and deleted assets during watch mode rebuilds, and removes stale bundle and manifest output files when entry points or exports change.
638cdb6 to
202d2f0
Compare
There was a problem hiding this comment.
Code Review
This pull request implements asset and output cleanup in watch mode for the library builder. It introduces tracking for emitted bundle files, manifest files, and assets, ensuring that files are correctly removed from the output directory when their source files are deleted or when entry points are removed. My review highlights a potential issue where source files matching multiple asset patterns might not be fully cleaned up due to the current emittedAssets map structure, and suggests using path.posix.join for consistency when handling output paths.
1 participant
Ensure the library builder properly handles created, modified, and deleted assets during watch mode rebuilds, and removes stale bundle and manifest output files when entry points or exports change.