Repository navigation
docs: update SECURITY.md - #34346
Open
dgp1130 wants to merge 1 commit into
Open
docs: update SECURITY.md#34346dgp1130 wants to merge 1 commit into
SECURITY.md#34346dgp1130 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates SECURITY.md to document the team's security policies and technical invariants regarding what constitutes a security vulnerability in Angular. The feedback suggests a minor correction to ensure consistent casing of 'DoS' throughout the document.
Comment on lines
+18
to
+19
| * Memory leaks are considered general bugs, not DOS vulnerabilities. | ||
| * While any memory leak is technically a DOS vulnerability in SSR, these are generally low enough impact to not be considered security issues. |
There was a problem hiding this comment.
For consistency with the rest of the document (which uses 'DoS' on lines 9, 11, 16, and 32), 'DOS' should be written as 'DoS'.
Suggested change
| * Memory leaks are considered general bugs, not DOS vulnerabilities. | |
| * While any memory leak is technically a DOS vulnerability in SSR, these are generally low enough impact to not be considered security issues. | |
| * Memory leaks are considered general bugs, not DoS vulnerabilities. | |
| * While any memory leak is technically a DoS vulnerability in SSR, these are generally low enough impact to not be considered security issues. |
dgp1130
force-pushed
the
security-policy
branch
2 times, most recently
from
October 14, 2026 23:21
40bb95c to
c748581
Compare
Adding some feedback based on AI security reports to help guide them towards what is and is not a legitimate vulnerability.
dgp1130
force-pushed
the
security-policy
branch
from
October 14, 2026 23:21
c748581 to
2c6a309
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding some feedback based on AI security reports to help guide them towards what is and is not a legitimate vulnerability.