Repository navigation
Handle unsupported metrics, rename protobuf field - #968
Merged
Merged
Conversation
* Make partially supported fields in `NetworkProtocolCounters` of
protobuf optional. Those fields are `{received,transmitted}_bytes`,
`{received,transmitted}_drops`, `{received,transmitted}_errors`.
Instead of filling unsupported metrics value with 0, leave them nil so
that receiver can distinguish it.
* Rename `protocol` to `network_protocol` in protobuf. The same in
`ContainerStatistics` (i.e., `protocol` to `networkProtocol`).
JaewonHur
force-pushed
the
handle-unsupported-metrics
branch
from
October 15, 2026 22:07
6030c0d to
29dc0c0
Compare
adityaramani
approved these changes
Oct 15, 2026
dkovba
reviewed
Oct 15, 2026
| public var receivedErrors: UInt64 | ||
| public var transmittedErrors: UInt64 | ||
| public var receivedErrors: UInt64? | ||
| public var transmittedErrors: UInt64? |
Contributor
There was a problem hiding this comment.
Was this actually needed? Making these counters optional breaks the callers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make partially supported fields in
NetworkProtocolCountersof protobuf optional. Those fields are{received,transmitted}_bytes,{received,transmitted}_drops,{received,transmitted}_errors.Instead of filling unsupported metrics value with 0, leave them nil so that receiver can distinguish it.
Rename
protocoltonetwork_protocolin protobuf. The same inContainerStatistics(i.e.,protocoltonetworkProtocol).