Repository navigation
Fix imported_from_german_feeds for central codeweek.de events - #3679
Merged
Merged
Conversation
imported_from_german_feeds only checked legacy city codes (cw-bonn etc.), so central-feed events with cw-codeweek-de were wrongly flagged false. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/events/germanysetsimported_from_german_feedsviaEvent::imported().bonn,hamburg, …).source_reflikecodeweek-de:{uid}and oftencw-codeweek-de, so they were returned asfalse.Also treat as imported when:
source_refstarts withcodeweek-de:mass_added_forisAPI codeweek_decodeweek-deTest plan
php artisan test --filter=it_should_return_german_events/api/events/germany?year=2026for events 1518065 / 1518017 showsimported_from_german_feeds: trueMade with Cursor