Repository navigation
Conversation
add_in_memory_file stored the path exactly as given (e.g. with "/"), while lookups go through get_in_memory_key, which rebuilds the path and uses "\" on Windows. The keys never matched there, so shim_filesystem::tests::in_memory_filesystem_shim always failed on Windows. Store file and directory keys through get_in_memory_key as well. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
while I was working on building a tool that provides an overview of the language rules covered by which unit test, I also saw that something is off there. thanks for pointing this out. I'd have to take some time time to read up on this in detail, as I've not worked on that area before really. @NSoiffer what do you think? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm playing with the Dutch math notation (#231). To ensure everything is working I ran the tests. There is 1 failure on Windows.
Reproduce with:
My skill with Rust is not (yet) sufficient to debug this, but I had help. Details are in the commit.
My focus is on YAML rule development and sparking discussions about gaps in the Dutch notation, but I wanted to share this finding while I'm at it.