Repository navigation
fix: report malformed pyproject TOML as a CLI error - #508
Open
AgiKukudala wants to merge 1 commit into
Open
AgiKukudala wants to merge 1 commit into
AgiKukudala wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed TOML in
pyproject.tomlcurrently escapes the CLI's configuration error handling as an uncaughtTOMLDecodeError. Bothfastapi devandfastapi runnow printInvalid TOML in pyproject.toml:with the parser's diagnostic and exit with status 1 before starting Uvicorn.The configuration reader translates syntax errors to
FastAPICLIException; existing Pydantic validation diagnostics remain unchanged. Regression tests cover an incomplete table declaration and a duplicate entrypoint for both commands, and fail on the unchanged code.Validation: 105 tests passed on Python 3.10; mypy, ty, Ruff lint and formatting checks passed.
Prepared with assistance from OpenAI Codex; the diff was reviewed and the checks above were run locally.