Repository navigation
feat(calendars): resolved days, range delete and optional summary - #101
Merged
Merged
Conversation
Sync the OpenAPI spec and regenerate. Calendars: - CalEventListResponse.Days: resolved state of every day in the scope, keyed by YYYY-MM-DD, as the new CalDay (IsOff, EventID, Layer). - CalEventIDRequest gains StartAt/EndAt to clear a date range; EventID is now optional (pass one form or the other). - CalEventUpsertRequest.Summary is optional. Also picked up from the spec: - ScheduleFixedTimeNotifyInfo: week/month cycles and Days. - LicenseListResponse.ReleaseLimited. - Work item status fields document their allowed values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
make sync-spec(flashduty-docs main) +make generate.Calendars
CalEventListResponse.Days map[string]CalDay— resolved state of every day in the requested scope, keyed byYYYY-MM-DD. NewCalDay{IsOff, EventID, Layer};Layeriscustom/holiday/weekly.CalEventIDRequestaddsStartAt/EndAt(clear the calendar's own events off[start_at, end_at));EventIDbecomesomitempty. Pass eitherEventIDor both dates.CalEventUpsertRequest.Summarybecomesomitempty.CalEventDelete/CalEventList/CalEventUpsertupdated from the spec.Other spec changes picked up by the sync
ScheduleFixedTimeNotifyInfo:Cycledocumentsday/week/month; newDays []int64.LicenseListResponse.ReleaseLimited bool.Status/TargetStatusfield docs list the allowed values.All changes are additive or doc-only; no field removed or retyped.
Checks
go build ./...,go vet ./...go test -race ./...— all packages pass