Repository navigation
docs: describe masked secrets in integration settings - #104
Merged
Merged
Conversation
Sync the integration descriptions from flashduty-docs: list, detail and update responses return each saved secret in settings as ******, and an update keeps a stored secret only while its destination is unchanged. Only the integration description changes are applied to the vendored spec; the rest of openapi/ is left as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Syncs the integration description changes from flashduty-docs into the vendored spec and regenerates
models_gen.go. Comment-only change; no types or fields change.IntegrationDetail.Settings/ list itemSettings: each saved secret is returned as******; unset values stay empty.Settings: a stored secret is kept only while its destination is unchanged.Why not
make sync-specmainvendors spec additions (Automationrun_in,AutomationExecutionLocation) that are not on flashduty-docsmainyet. A fullmake sync-specwould remove them. This PR applies only the integration description lines, so the rest ofopenapi/is unchanged.Tests
make fmt(no changes),make test(race) andgo build ./...pass.