Repository navigation
ci: run CI on integration branches - #1218
Merged
EtienneLescot merged 1 commit intoOct 14, 2026
Merged
Conversation
integration/shader-effects collects the shader effects PRs before they go to main, and nothing checked them: ci.yml triggered on main, feat/ai-edition and release/** only. Those PRs change native code for Windows, macOS and Linux, and each author can build one of the three.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci.ymlruns on pull requests and pushes tomain,feat/ai-editionandrelease/**. A PR tointegration/shader-effectstherefore gets no lint, no typecheck, no tests and no PR-title check, and that branch collects the shader effects PRs before they go to main.This adds
integration/**to both triggers, with a line in the comment that explains the list. Those PRs change native code for Windows, macOS and Linux, and each author can build only one of the three: #1206, #1219 and #1220 were written on a Mac, and #1219 touches the D3D11 and wgpu backends too.Related issue
None. Part of the shader effects work on
integration/shader-effects.Type of change
Release impact
Desktop impact
Testing
npx vitest --run .github: 7 files, 56 tests pass (macos-runner-images.test.mjsreadsci.yml).integration/shader-effectsneeds a new push (or a re-sync) to get its first CI run.