Repository navigation
Adopt shadcn Nova menus and buttons, with contextual icon sizes - #625
Merged
Merged
Conversation
MaggieAppleton
force-pushed
the
menu-standard
branch
5 times, most recently
from
October 15, 2026 11:19
eef1c2e to
c402a38
Compare
Menus: 4px panel, 28px items (4px by 6px padding, 6px gap, medium radius), edge-to-edge 1px dividers with 4px above and below. Normal and compact density now match. Buttons: btn-xs 24px, btn-sm 28px, btn-md 32px, btn-lg 36px, btn-icon-xs and btn-icon; btn-compact becomes btn-xs. Each size sets its icon through --btn-icon-size: 12px at xs, 14px at sm, 16px above. Icons default to 16px. Size is contextual: 16px in menus, buttons and standalone, 14px beside small text such as badges, 12px in compact controls. DESIGN.md records the menu, button, icon and progressive-disclosure rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
packages/icons/src/icon.tsx changed only its default size from 14 to 16. Its props still spread onto the <svg> as before; caller styling flows the same way. Renewal approved by the design owner in session. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nova's btn-sm uses the extra-small text role, which left Reopen and Discard smaller than the attribution and "Show in document" beside them. The resolved footer's buttons keep the small text role, as its link already does. The icon-size check now expects the size a button sets through --btn-icon-size rather than the icon's declared width, since the button decides its icon size. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The "Show in document" link's negative margin now matches btn-sm's 10px padding, so its glyph lines up with the attribution avatar again, and the avatar returns to 14px beside the small attribution text to match the 14px icon btn-sm sets. The resolved footer uses Nova's 4px button gap so the link and both actions still fit one line at phone width, and wraps rather than squeezing the link when a card is narrower. The icon-size check measures each icon's intended size from an out-of-flow copy, so icons a container sizes in CSS (btn-sm, compact icon buttons) are compared with that size rather than their width attribute. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The 20 files whose reviews this PR voids change only icon sizes (14 to 16, icon defaults), btn-compact to btn-xs, size-3.5 to size-4, and a literal text-sm on four resolved-footer buttons. No class, style or spread data flow changed. Approved by the design owner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reopen, Discard and the confirm prompt keep btn-sm's own extra-small text instead of overriding it, and the Show in document link and the decision's attribution use the same --text-xs role, so the settled card's footer reads as one quiet size, as every other small button does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Only literal text-size classes changed in resolved-actions.tsx and card.tsx; no class, style or spread data flow changed. Approved by the design owner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… after rebase Only icon sizes and btn-compact to btn-xs changed on top of main; no class, style or spread data flow changed. Approved by the design owner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…controls After rebasing onto the sidebar audit work, only icon sizes (14 to 16) changed in account-menu.tsx, project-sidebar.tsx and design-audit/controls.tsx; no class, style or spread data flow changed. Approved by the design owner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaggieAppleton
force-pushed
the
menu-standard
branch
from
October 15, 2026 11:30
c402a38 to
f892104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts shadcn's Nova style as the standard for menus and buttons, makes icon size contextual, and records the rules in
apps/web/DESIGN.md.Menus
Shared
--menu-*tokens and.app-menu-item/.app-menu-separatornow follow Nova:Buttons
btn-xs24px,btn-sm28px,btn-md32px,btn-lg36px, plus icon-onlybtn-icon-xs(24px) andbtn-icon(28px).btn-compactbecomesbtn-xs(20 uses).btn-smgrows from 24px to 28px (80 uses).--btn-icon-size: 12px at xs, 14px at sm, 16px at md and lg.Icons
LineIconnow defaults to 16px, and explicit 14px icons are now 16px.Size is contextual:
IconLabelstays at 14px), pills, capsules and small buttons.Design contract
packages/icons/src/icon.tsxchanged only its default size, and its props still spread onto the<svg>as before. Its reviewed exception is renewed in a separate commit, approved by the design owner.Verification
bun run typespasses.bun testshows no new failures against a clean base on the same machine. The design-contract, design-record, dprint and oxlint checks pass on the changed files.btn-smis 4px taller, so layout assertions may move; CI will tell.🤖 Generated with Claude Code