Repository navigation
Render the live workspace chrome in the design audit - #630
Merged
Merged
Conversation
MaggieAppleton
force-pushed
the
audit-split-plates
branch
from
October 15, 2026 10:16
6bc3284 to
4585d35
Compare
MaggieAppleton
force-pushed
the
audit-workspace-chrome
branch
from
October 15, 2026 10:18
4b769c8 to
2c0a70a
Compare
The Navigation plate's compact view navigation and the Loading and status plate's header row were hand-built imitations. Extract the live pieces so the app and the audit render one component: - WorkspaceViewNavigation (workspace-navigation.tsx), the compact workspace's Chat / Document / Decisions / Build row, with destinationLabel. - DocumentTitleBar (document-title-bar.tsx), the split sheet's title bar and the views bar beneath it. - LostEditsNotice and UndoRefusedNotice (document-status-notices.tsx), the notices beside PlanStatus. Each is a pure move: markup, classes, data attributes and handlers are unchanged. The plates now render them with live states, the Tabs plate adds DecisionViewControl's Build and document-activity states, and the audit CSS that overrode .workspace-navigation and faked the header row is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
workspace.tsx moved its compact view navigation and title bar into workspace-navigation.tsx and document-title-bar.tsx; design-audit/controls.tsx gained view-control specimens. The reviewed dynamic sinks (the surface toggle's motion feedback class, the Chat panel's presence classes, ButtonRow's class forwarding) are unchanged. Approved by the design owner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaggieAppleton
force-pushed
the
audit-workspace-chrome
branch
from
October 15, 2026 10:47
2c0a70a to
8e7ae66
Compare
MaggieAppleton
enabled auto-merge (rebase)
October 15, 2026 11:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #626. Part of making the design audit page render the live app instead of hand-built imitations.
What was fake
buildEnabled,buildGlyphanddocumentActivitystates.What it renders now
WorkspaceViewNavigationin five live states:DocumentTitleBar, holding the realSurfaceToggle,DecisionViewControlandPlanStatus, plus the live "Can't undo" and "Edits not saved" notices.DecisionViewControlwhile the Planner is writing, with unseen changes, Build not ready, ready, selected and hot.Extractions
These are pure moves: markup, classes, data attributes, aria and handlers are unchanged.
WorkspaceViewNavigationanddestinationLabelmove toapps/web/src/workspace-navigation.tsx.DocumentTitleBarmoves toapps/web/src/document-title-bar.tsx. It keeps thedocument-title-barcontainer anddata-document-title-bar, plus the views bar'sdata-document-toolbar,data-foldedandinert.LostEditsNoticeandUndoRefusedNoticemove toapps/web/src/document-status-notices.tsx.Removed audit CSS
The compact-navigation grid override, its button rule, and
.design-audit-status-header.Design contract
workspace.tsxanddesign-audit/controls.tsxchanged, so their reviews are renewed in a separate commit. Their reviewed dynamic sinks are unchanged.Verification
bun run types,bun test apps/web(787 pass), the design-contract and token checks, and oxlint.apps/web/src/workspace-chrome.test.ts.e2e/designbaselines for the navigation, loading and tabs plates. The e2e suite was not run locally.🤖 Generated with Claude Code