Skip to content

Remove activity-types class from _commit_table #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ImTheKai merged 1 commit into from
Sep 22, 2026
Merged

Remove activity-types class from _commit_table #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/shared/profile/_commit_table.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
- commit_rows.each do |row|
- commit = row[:commit]
tr
td.activity-types
td
- if show_members
- row[:member_credits].each do |credit|
- member_alias = credit[:person].default_alias
Expand Down
2 changes: 1 addition & 1 deletion spec/requests/team_commits_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def attach_verified_alias(user, email:, name: 'Member')
rows = doc.css('table.commit-activity-table tbody tr')
expect(rows.size).to eq(1)

credits = rows.first.css('td.activity-types .commit-member-credit')
credits = rows.first.css('td .commit-member-credit')
expect(credits.size).to eq(2)

# one tuple per member: separate per-attribute lists would still pass if
Expand Down
Loading