Repository navigation
Update MCP coverage after Node SDK releases - #213
Conversation
There was a problem hiding this comment.
Semgrep triage: 5 inline comments below, 1 omitted (same mutable-tag issue on actions/checkout@v4 at line 28, in the sdk-version job, which has no secrets). The workflow_run checkout finding is a false positive: Publish NPM runs only on release or dispatch, and the job requires head_repository == github.repository. The Redis port finding is also a false positive, since it only affects an ephemeral CI service container.
meliaj
left a comment
There was a problem hiding this comment.
lgtm.
non-blocking follow-up: consider separating generation from publishing, with a clean publishing job receiving only the validated source snapshot. not a blocker under the stated trust model.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 374931c. Configure here.
|
the unversioned-spec finding looks valid: the diff is release-bounded, but Pi reads the full spec from current main. could we retain the historical target spec and point Pi at that instead? i couldn’t reproduce the UTC lookup issue—equivalent raw and URL-encoded |
|
@meliaj your non-blocking follow-up is done in 05c1d96. Generation and publishing are now separate jobs.
Verification also now rejects Separately, Pi now reads the spec as of the SDK release commit instead of current |

Summary
openapi.yaml) as of the SDK release, plus a spec diff since the previous release. Pi updates tool, action, and input descriptions for changed spec text, adapting API-native wording rather than copying it.package.json,bun.lock,.ts/.tsxundersrc/, excluding generated bundles). It then cleans the checkout and validates that patch: SDK pin with no overrides, frozen install, bundle check, type check, tests, and the Redis recording check.Validation
actionlint passed. The 8 committed CI security tests pass, and CI is green on the latest commit.
25 local fixture tests passed across both updaters. They cover:
External commands were mocked; Git ran against local repositories. Mutation checks confirmed the tests fail when the allowlist or the pre-agent snapshot base is removed.
Not yet run: a live Pi run, a generated MCP update, or a full end-to-end GitHub Actions run. Secret and variable availability couldn't be verified with the available GitHub permissions.