Repository navigation
feat(junit): allow OptionsFactory to access test instance fields - #2008
Open
Yury Semikhatsky (yury-s) wants to merge 2 commits into
Open
Yury Semikhatsky (yury-s) wants to merge 2 commits into
Yury Semikhatsky (yury-s) wants to merge 2 commits into
Conversation
Yury Semikhatsky (yury-s)
requested review from
Devin Rousso (dcrousso) and
Dmitry Gozman (dgozman)
October 15, 2026 01:01
Devin Rousso (dcrousso)
approved these changes
Oct 16, 2026
Comment on lines
+80
to
+81
| Constructor<? extends OptionsFactory> constructor = factoryClass.getDeclaredConstructor(factoryClass.getDeclaringClass()); | ||
| constructor.setAccessible(true); |
Contributor
There was a problem hiding this comment.
i think we need to use extensionContext.getExecutableInvoker().invoke(constructor, enclosingInstance) instead so JUnit creates the factory with its existing access as otherwise this would fail in named modules that open the test package to JUnit but not Playwright
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OptionsFactorypassed to@UsePlaywrightcan now be a non-static inner class of the test class, so options can depend on instance fields (e.g. a server injected by Spring/Micronaut).PlaywrightandBrowserare still created once from the first instance's options.Fixes #1881