Repository navigation
Conversation
kolyshkin
reviewed
Oct 15, 2026
kolyshkin
left a comment
kolyshkin
left a comment
Collaborator
There was a problem hiding this comment.
The fix LGTM, I'm against adding a test case as the code is trivial and there's no need to check it.
Author
|
The test is gone. The skip stays, next to the other directory skips. |
Collaborator
|
@SashaMIT please squash your commits |
Incus creates /dev/.incus-mounts mode 0700. GetDevices recursed into it and failed the whole listing with permission denied. .lxc, .lxd-mounts, and .udev are already skipped for that reason. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
SashaMIT
force-pushed
the
fix/incus-mounts
branch
from
October 17, 2026 15:34
8203ffb to
6b651fb
Compare
Author
|
Squashed to one commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetDevices walks every directory it is given. Incus creates
/dev/.incus-mountswith mode 0700, and reading that directory returns permission denied, so the whole listing fails..lxc,.lxd-mounts, and.udevare already skipped for the same reason..incus-mountsis skipped too.An unreadable directory with any other name still returns that error.
Red:
GetDevices: permission denied. Green: nil.go test -count=1 .indevicespassed.Fixes #260