Repository navigation
fix(platform): guard against unverified CPU architectures - #95
Merged
namanONcode merged 1 commit intoOct 12, 2026
Merged
Conversation
StructLayouts hardcodes the epoll_event struct as a 12-byte packed layout, which is only correct on x86_64 - the Linux kernel's own eventpoll.h applies the packed attribute solely when __x86_64__ is defined. On other 64-bit architectures (aarch64 included) the real layout is 16 bytes, so running there would silently misread events, including via raw kernel writes into a buffer sized for the wrong struct - outside anything the FFM API's bounds checking can catch. Platform.ensureLinux() only checked the OS, not the architecture, and the existing isAarch64()/isX8664() detection methods were never actually called anywhere at runtime. Add Platform.ensureSupportedArchitecture(), called from LinuxRuntimeFactory right after the existing OS check, so unsupported architectures fail fast with a clear ConfigurationException instead of silently corrupting memory. Covered by new PlatformTest cases and noted in the changelog. Ref: ZT-01 in the earlier code review.
Owner
|
@aaditya-dakhore raise issue first then continue |
Contributor
Author
|
Closes #97 |
namanONcode
enabled auto-merge
October 12, 2026 10:11
namanONcode
self-requested a review
October 12, 2026 10:11
namanONcode
disabled auto-merge
October 12, 2026 10:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Linux runtime currently verifies that the operating system is Linux but does not verify that the CPU architecture is supported.
The native struct layouts used by zThread's Linux implementation are verified for x86_64. Running on an unverified architecture may result in incorrect native memory interpretation and unsafe runtime behavior.
The runtime should fail fast with a clear
ConfigurationExceptionwhen the CPU architecture has not been verified.Motivation
Failing safely is preferable to allowing the runtime to use an unverified native struct layout that could cause memory corruption or incorrect event handling.
This is a defensive safety fix. It does not add AArch64 support; support for additional architectures is tracked separately in #96.
Changes
Platform.ensureSupportedArchitecture()to reject unverified CPU architectures.LinuxRuntimeFactory.CHANGELOG.md.Testing
./mvnw clean verify) on Kali Linux x86_64../mvnw verify -Pquality).Note: The prescribed quality profile encountered a Google Java Format version incompatibility with JDK 25. The separate Checkstyle, PMD, and SpotBugs checks completed successfully.
Checklist
./mvnw spotless:apply).CHANGELOG.mdupdated.