Repository navigation
Conversation
Original commit message:
[heap] Always decrement age in RetainMaps()
When the prototype and constructor were already marked we did not
age the map because of the assumption that this would only keep the
transition tree alive. However, this does not hold because of
the JSFunctions inside an AccessorPair in DescriptorArray.
This can result in retaining maps indefinitely when not triggering
memory reducing GCs. This CL therefore simplifies the code to
always age maps instead. This is neutral on Speedometer and Jetstream.
Bug: 571157135
Change-Id: I8fb633a0ec0c1d66e4596390ca48e1c7006c9cc2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8557820
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#110622}
Fixes: nodejs#66490
Refs: v8/v8@497c2e6
Assisted-by: Codex
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
inoway46
marked this pull request as ready for review
October 14, 2026 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport the upstream V8 fix for indefinitely retained maps and increment
v8_embedder_string.This affects real-world Jest workloads, where retained contexts substantially increase memory usage, making the fix worth including in Current.
Upstream fix: https://chromium-review.googlesource.com/c/v8/v8/+/8557820
The v26.11.0 reproduction retained 1→8 contexts before the fix and 0 throughout with it applied: https://github.com/inoway46/node/actions/runs/38432566001
Refs: #66490
This targets
v26.x-stagingdirectly, following the discussion in #66710;maincan pick up the fix through a V8 update.