Repository navigation
[v26.x] deps: V8: cherry-pick c21a93ec80d5 - #66729
Open
barathraj048 wants to merge 1 commit into
Open
barathraj048 wants to merge 1 commit into
barathraj048 wants to merge 1 commit into
Conversation
Original commit message:
[sandbox] Fix JSDispatchTable entry mark-bit erasure
A race condition exists in V8's concurrent marking and deoptimization
logic where Code::SetMarkedForDeoptimization updates a dispatch table
entry without running a write barrier. During concurrent marking, a
background thread's CAS mark can be overwritten by the mutator's blind
store, leading to a live entry being swept.
Fixed: 525686865
Change-Id: I0cebd44b62ad5c16c19d73e5586058b1d2265ee4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8074259
Commit-Queue: Olivier Flückiger <olivf@chromium.org>
Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
Auto-Submit: Olivier Flückiger <olivf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108583}
Refs: v8/v8@c21a93e
Signed-off-by: Barath <barathraj048@gmail.com>
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@c21a93e
Fixes: #66661
Notes for reviewers:
cleanly with
git am -3.v8_embedder_stringbumped to -node.40.complete fix, is not included here.
on demand, and the upstream commit did not add one.
vcbuild.bat teston Windows x64. All tests pass excepttest-child-process-exec-any-shells-windows, which fails with EACCES on
the WindowsApps bash.exe app execution alias. It fails the same way on
a main build (v27.0.0-pre) without this change, so it's
environment-specific and unrelated.
cc @nodejs/v8