Skip to content

build,test: setup perfetto tests on windows build - #66731

Open
legendecas wants to merge 1 commit into
nodejs:mainfrom
legendecas:perfetto-win
Open

legendecas wants to merge 1 commit into
nodejs:mainfrom
legendecas:perfetto-win

Conversation

@legendecas

Copy link
Copy Markdown
Member

This converts the trace_processor_shell script to a python script so that it
can be ran on Windows as well. This also adds a flag with-perfetto in
vcbuild.bat to build Node.js with perfetto support.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Oct 14, 2026
@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.47%. Comparing base (4599b6a) to head (cda8a37).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66731      +/-   ##
==========================================
- Coverage   90.48%   90.47%   -0.01%     
==========================================
  Files         791      791              
  Lines      277204   277204              
  Branches    53311    53306       -5     
==========================================
- Hits       250828   250804      -24     
- Misses      16796    16813      +17     
- Partials     9580     9587       +7     

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
@legendecas legendecas changed the title test: setup perfetto tests on windows build build,test: setup perfetto tests on windows build Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants