Repository navigation
Conversation
An empty reference passed to process.permission.drop() fell through to dropping the whole scope, while has() treats it as not granted. Throw ERR_INVALID_ARG_VALUE instead, in both the JS wrapper and the binding. Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66732 +/- ##
==========================================
- Coverage 90.48% 90.47% -0.02%
==========================================
Files 791 791
Lines 277204 277216 +12
Branches 53311 53310 -1
==========================================
- Hits 250841 250803 -38
- Misses 16760 16812 +52
+ Partials 9603 9601 -2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
permission: reject empty reference in drop()