Repository navigation
Conversation
Enable V8_ENABLE_UNDEFINED_DOUBLE in the V8 GYP configuration, matching the setting added on main by 8394db3. This is a candidate for the repeated wrong-map deoptimizations in big.js reported in nodejs#66717. Preserve the existing v26 GYP settings and apply only the undefined double feature configuration. Refs: nodejs@8394db3 Refs: nodejs#66717 Signed-off-by: inoway46 <inoueyuya416@gmail.com> Assisted-by: Codex
Collaborator
|
Review requested:
|
This comment was marked as resolved.
This comment was marked as resolved.
nodejs-github-bot
added
needs-ci
Contributor
Author
|
A before/after comparison is running on macOS arm64: It builds the parent commit and this PR’s commit, then runs the reproduction with five seeds, both with and without Maglev. I’ll share the results once it completes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable
V8_ENABLE_UNDEFINED_DOUBLEin the V8 GYP configuration, matching the setting added on main by 8394db37d800.With this change, a local d8 build no longer exhibits the repeated wrong-map deoptimizations from #66717. This was verified with five seeds, both with and without Maglev.
Refs: #66717