Skip to content

Document Daitch-Mokotoff translation - #472

Merged
roji merged 1 commit into
mainfrom
roji-daitch-mokotoff-documentation
Oct 15, 2026
Merged

roji merged 1 commit into
mainfrom
roji-daitch-mokotoff-documentation

Conversation

@roji

@roji roji commented Oct 15, 2026

Copy link
Copy Markdown
Member

Documents the translation introduced by npgsql/efcore.pg#3922, which is currently open, on the EFCore.PG translations page.

  • Add EF.Functions.FuzzyStringMatchDaitchMokotoff(text) → daitch_mokotoff(text), marked as an EFCore.PG 11.0 addition requiring PostgreSQL 16+.
  • Correct the fuzzy string match section's extension reference to fuzzystrmatch.
  • Note the nullable array result and the current LINQ composition limitation tracked by dotnet/efcore#35980, without adding unsupported examples.

Validation: Markdownlint passed for the changed page; git diff --check passed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bef3c291-4d50-4144-83a8-609d01f54c7a
Copilot AI balanced review requested due to automatic review settings October 15, 2026 12:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused documentation update matches the implementation and tracked limitations, with no unresolved findings.

0 open findings

What changed in this PR

Documents the Daitch-Mokotoff translation in EFCore.PG’s translation reference.

Changes:

  • Adds the translation with EFCore.PG 11.0 and PostgreSQL 16+ requirements.
  • Corrects the extension reference to fuzzystrmatch.
  • Documents nullable results and current LINQ composition limitations.
File Description
conceptual/​EFCore.PG/​mapping/​translations.md Adds Daitch-Mokotoff support details and corrects the extension reference.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@roji
roji merged commit 8bb3d92 into main Oct 15, 2026
2 of 3 checks passed
@roji
roji deleted the roji-daitch-mokotoff-documentation branch October 15, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants