Repository navigation
Make mostrecent gauge tests independent of clock resolution - #1219
Merged
csmarchbanks merged 1 commit intoOct 14, 2026
Merged
Conversation
Signed-off-by: nischita44 <nischitasadananda@gmail.com>
chrikrah
approved these changes
Oct 14, 2026
chrikrah
left a comment
Contributor
There was a problem hiding this comment.
@nischita44 the fix holds up under an independent repro: master fails only with a constant clock and reversed glob order together, and head passes that same case.
$ PYTHONPATH=. python cp_mostrecent_tie.py # runs test_gauge_mostrecent and test_gauge_livemostrecent; Python 3.12.3
# master 9cd073c
clock=real order=reversed run=2 failures=0 errors=0
clock=constant order=forward run=2 failures=0 errors=0
clock=constant order=reversed run=2 failures=2 errors=0
# head 7bc7090
clock=constant order=reversed run=2 failures=0 errors=0
The probe patches time.time to return 1000.0 and prometheus_client.multiprocess.glob.glob to return sorted or reverse-sorted paths.
@csmarchbanks, this touches tests only. Is anything keeping it out of the next release?
csmarchbanks
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #942
test_gauge_mostrecent and test_gauge_livemostrecent call set() twice back to back. In mostrecent mode each set() is stamped with time.time(). On a platform with coarse clock resolution, both stamps can be equal. MultiProcessCollector only replaces a value when the timestamp is strictly greater, so on a tie the result depends on the order glob returns the .db files, which is filesystem-dependent. This matches the 1 != 2.0 failure reported on Alpha.
This patches time.time in both tests to return increasing values, so the second write is always newer. Test-only change, no library code touched.
I reproduced the original failure locally by forcing a constant clock and reversed file order; both tests fail before this change and pass after.