Repository navigation
Exercise HTTP 300 responses in redirect caching tests - #478
Closed
ryanduguid wants to merge 1 commit into
Closed
ryanduguid wants to merge 1 commit into
ryanduguid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The multiple-choice redirect tests request an undefined route and receive the fixture's default HTTP 200 response. Use the existing HTTP 300 handler with explicit freshness, assert the response status and cached body, and verify the cache is populated before testing
no-cache.Fixes #184.
Evidence
no-cacherequests.Merge danger
Door: two-way. Blast radius: tests.
The change is confined to the HTTP 300 fixture and its existing tests.
Unverified
macOS, Windows Python 3.10 through 3.13 and upstream CI were not run. Codespell reports the same two existing
unparseableoccurrences intests/test_cache_control.pyon the baseline and candidate. Linux Python 3.13/3.14 emit Cheroot socket shutdown warnings; the same warning also appears in the Python 3.14 baseline.