Skip to content

[3.15] gh-126547: pre-allocate version number for unicode type (GH-157781) - #157812

Merged
encukou merged 1 commit into
python:3.15from
miss-islington:backport-c2e740a-3.15
Oct 15, 2026
Merged

encukou merged 1 commit into
python:3.15from
miss-islington:backport-c2e740a-3.15

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

(cherry picked from commit c2e740a)

Co-authored-by: Inada Naoki songofacandy@gmail.com

…GH-157781)

(cherry picked from commit c2e740a)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@methane

methane commented Sep 19, 2026

Copy link
Copy Markdown
Member

This fix adds the preallocated value to UnicodeType.tp_version_tag, which was inadvertently omitted in the following PR.

#126551

Not setting this may have a small impact on the performance of the Tier 2 optimizer, but it does not affect correctness, so it is not a release blocker. I believe the backport is safe, but I will leave the decision to the release manager.

@encukou
encukou requested a review from hugovk October 12, 2026 13:07
@encukou

encukou commented Oct 13, 2026

Copy link
Copy Markdown
Member

I'd call this a bugfix. I'll merge ~Thursday if there are no objections.

@encukou
encukou merged commit b65c01c into python:3.15 Oct 15, 2026
55 checks passed
@miss-islington
miss-islington deleted the backport-c2e740a-3.15 branch October 15, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants