Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPU mode can attribute samples to a suspended stack when another thread state uses the same native thread. Use the binding status and stacks already collected to prefer a bound, nonempty stack. Preserve the existing attribution when no such stack is present, including native work after a callback deletes or empties its temporary state.
Only samples containing an unbound stack run the local filter. It uses a temporary set and two passes over the collected results, with no additional remote reads or OS thread-status queries. Ordinary bound-state samples add only local checks. The regression uses the existing test helper.
External-inspection and profiling tests pass on regular and free-threaded debug builds, with 547 tests on each; the regression also passes reference-leak checks. Linux syscall counts match the original code for ordinary, duplicate-state, and callback-return samples, with frame caching on and off. In cached ALL-mode debug measurements, median sample times were 6.14 to 6.09 microseconds for ordinary sampling, 19.85 to 20.31 for duplicate states, and 29.00 to 29.56 after a callback. The unusual cases still incur local filtering work.