Repository navigation
[mypyc] Fix over-decref in async for over a non-async iterable - #22208
Merged
Merged
Conversation
CPy_GetAIter called Py_DECREF on its argument when the object has no `__aiter__`. The code was adapted from ceval.c, where GET_AITER owns the stack reference, but the primitive receives a borrowed reference, so each failing 'async for' freed the iterable one reference too early and could later segfault.
p-sawicki
approved these changes
Oct 15, 2026
Collaborator
Author
|
#22209 should fix the CI failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPy_GetAIter called Py_DECREF on its argument when the object has no
__aiter__. The code was adapted from ceval.c, where GET_AITER owns the stack reference, but the primitive receives a borrowed reference, so each failing 'async for' freed the iterable one reference too early and could later segfault.