Repository navigation
Fix CI: add missing Remotes for ccflowR + presto (dependency-resolution failure) - #3
Merged
Merged
Conversation
R-CMD-check and lint have failed on main at the "Setup R dependencies"
step since the package was set up: DESCRIPTION declares `ccflowR` and
`presto` under Suggests, but `Remotes:` only covered nichenetr and
multinichenetr, so pak could not locate these GitHub-only packages
("Could not solve package dependencies: Can't find package called
ccflowR, presto") and aborted before any checking ran.
Add the two missing remotes, matching the pins already used by
inst/bootstrap.R and the install docs:
- immunogenomics/presto (public)
- settylab/ccflowR@6056c0f (audited SHA)
Note: settylab/ccflowR is a PRIVATE repository. CI's default GITHUB_TOKEN
cannot read other private repos, so dependency setup will still fail to
clone ccflowR until the workflow is given a PAT secret with read access
to settylab/ccflowR (see PR description). presto resolves with the
default token.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
R-CMD-check(all 7 platform/version jobs) andlinthave been failing onmain— since the package was first set up — at the "Setup R dependencies"step, before any checking runs:
DESCRIPTIONdeclaresccflowRandprestounderSuggests:, butRemotes:only listed
nichenetrandmultinichenetr. BothccflowRandprestoareGitHub-only (not on CRAN/Bioconductor), so
pakcan't resolve them and thedependency solve aborts — taking down R-CMD-check and lint together.
This is independent of the tutorials work in #2; it fails on a clean
main.Fix
Add the two missing remotes, using the same sources/pins already in
inst/bootstrap.Rand the install docs:immunogenomics/presto(public) — resolves with CI's defaulttoken.
settylab/ccflowRat the audited commit6056c0fe1d1cecfc68aa059bacfbe6bd16725231(the SHA pinned ininst/bootstrap.R).settylab/ccflowRis a private repository. The CI workflow(
.github/workflows/R-CMD-check.yaml) authenticatessetup-r-dependencieswiththe default
GITHUB_TOKEN, which can only read this repo — not other privaterepos in the org. So with this PR alone,
pakwill get pastprestobut stillfail to clone the private
ccflowR, and CI will stay red.To fully green CI, one of:
Give CI a PAT with read access to
settylab/ccflowR(recommended). Createa repo/org secret (e.g.
CCFLOWR_PAT) holding a PAT (classicreposcope, ora fine-grained token with read access to
settylab/ccflowR), then pass it toeach
setup-r-dependenciesstep:(and likewise for the
lintandtest-coveragejobs). I did not add thisbecause it depends on a secret only a maintainer can create; happy to push the
workflow edit once the secret name is decided.
Or stop CI from installing the private optional dep — e.g. set
dependencies: '"hard"'on thesetup-r-dependenciessteps so onlyImports/Depends are installed. This greens CI without a PAT but skips all
Suggests-based example/test coverage (Seurat, nichenetr, …), so it's acoverage tradeoff worth a maintainer's call.
Verification
After this change, CI dependency resolution should no longer complain about
presto; the remaining failure (if the PAT secret isn't yet configured) will beon cloning the private
ccflowR, confirming the isolation above. Posting thecheck results in a comment.