Skip to content

Preserve browser query attribution for manual pageviews #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simple-analytics-ai wants to merge 11 commits into from
Closed

Preserve browser query attribution for manual pageviews #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8a554a9
Preserve distinct manual pageviews in v12
Oct 15, 2026
db8b76c
Preserve browser query attribution for manual pageviews
Oct 15, 2026
ed7f5ee
Preserve ignore-pages and hash routes for manual query paths
Oct 15, 2026
9a9efd0
Keep reviewed manual-path guards with browser query attribution
Oct 15, 2026
f5d84e4
Merge reviewed manual-path corrections into the attribution branch
Oct 15, 2026
ed0ccd7
Keep non-string manual paths compatible during query normalization
Oct 15, 2026
a09dfc9
Keep numeric manual paths compatible in the attribution stack
Oct 15, 2026
d3d6e56
Merge final manual-path compatibility guard into attribution branch
Oct 15, 2026
15e99ef
Preserve pathname-only input for path overwriters
Oct 15, 2026
2d3b160
Keep pathname-only callbacks in the attribution stack
Oct 15, 2026
10b02b1
Merge pathname-only callback correction into attribution branch
Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions dist/latest/cloudflare.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Simple Analytics - Privacy-first analytics (docs.simpleanalytics.com/script; 2026-09-16; b9db; v12) */
/* Simple Analytics - Privacy-first analytics (docs.simpleanalytics.com/script; 2026-10-15; efde; v12) */
/* eslint-env browser */

(function (
Expand Down Expand Up @@ -226,9 +226,9 @@

var k;

var getQueryParams = function (ignoreSource, overwriteSearch) {
var getQueryParams = function (ignoreSource) {
k = !ignoreSource && collectMetricByString("q") ? "" : falseVar;
var q = (overwriteSearch || loc.search)
var q = loc.search
.slice(1)
.split("&")
.filter(function (keyValue) {
Expand Down Expand Up @@ -675,15 +675,14 @@
isPushState,
deleteSourceInfo,
sameSite,
search,
metadata,
callback
) {
if (isPushState) sendOnLeave("" + payload.page_id, trueVar);
if (collectDataOnLeave) payload.page_id = uuid();

var currentPage = definedHostname + getPath();
var query = getQueryParams(deleteSourceInfo, search);
var query = getQueryParams(deleteSourceInfo);

sendData(
{
Expand Down Expand Up @@ -714,7 +713,7 @@
) {
if (!callbackRaw && isFunction(metadata)) callbackRaw = metadata;
var callback = isFunction(callbackRaw) ? callbackRaw : function () {};
var querySearch;
var querySearch = "";
if (isString(pathOverwrite) && pathOverwrite.indexOf("?") > -1) {
// keep query from manual path
var parts = pathOverwrite.split("?");
Expand All @@ -725,9 +724,10 @@
var path = getPath(pathOverwrite);

// Don't send the last path again (this could happen when pushState is used to change the path hash or search)
if (!path || lastSendPath == path) return;
var pathKey = path + querySearch;
if (!path || lastSendPath == pathKey) return;

lastSendPath = path;
lastSendPath = pathKey;
page.path = path;

// v = viewportsizes
Expand Down Expand Up @@ -801,7 +801,6 @@
isPushState,
delSrc, // r = referrers
sameSite,
querySearch,
metadata,
callback
);
Expand Down
4 changes: 2 additions & 2 deletions dist/latest/custom/app.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/latest/custom/app.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/latest/custom/e.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/latest/custom/e.js.map
View file
Open in desktop

Large diffs are not rendered by default.

17 changes: 8 additions & 9 deletions dist/latest/custom/latest.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Simple Analytics - Privacy-first analytics (docs.simpleanalytics.com/script; 2026-09-16; 3665; v12) */
/* Simple Analytics - Privacy-first analytics (docs.simpleanalytics.com/script; 2026-10-15; d620; v12) */
/* eslint-env browser */

(function (
Expand Down Expand Up @@ -224,9 +224,9 @@

var k;

var getQueryParams = function (ignoreSource, overwriteSearch) {
var getQueryParams = function (ignoreSource) {
k = !ignoreSource && collectMetricByString("q") ? "" : falseVar;
var q = (overwriteSearch || loc.search)
var q = loc.search
.slice(1)
.split("&")
.filter(function (keyValue) {
Expand Down Expand Up @@ -675,15 +675,14 @@
isPushState,
deleteSourceInfo,
sameSite,
search,
metadata,
callback
) {
if (isPushState) sendOnLeave("" + payload.page_id, trueVar);
if (collectDataOnLeave) payload.page_id = uuid();

var currentPage = definedHostname + getPath();
var query = getQueryParams(deleteSourceInfo, search);
var query = getQueryParams(deleteSourceInfo);

sendData(
{
Expand Down Expand Up @@ -714,7 +713,7 @@
) {
if (!callbackRaw && isFunction(metadata)) callbackRaw = metadata;
var callback = isFunction(callbackRaw) ? callbackRaw : function () {};
var querySearch;
var querySearch = "";
if (isString(pathOverwrite) && pathOverwrite.indexOf("?") > -1) {
// keep query from manual path
var parts = pathOverwrite.split("?");
Expand All @@ -725,9 +724,10 @@
var path = getPath(pathOverwrite);

// Don't send the last path again (this could happen when pushState is used to change the path hash or search)
if (!path || lastSendPath == path) return;
var pathKey = path + querySearch;
if (!path || lastSendPath == pathKey) return;

lastSendPath = path;
lastSendPath = pathKey;
page.path = path;

// v = viewportsizes
Expand Down Expand Up @@ -801,7 +801,6 @@
isPushState,
delSrc, // r = referrers
sameSite,
querySearch,
metadata,
callback
);
Expand Down
4 changes: 2 additions & 2 deletions dist/latest/custom/latest.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/latest/custom/latest.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/latest/custom/light.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/latest/custom/light.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/latest/custom/proxy.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/latest/custom/proxy.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading