Repository navigation
Accept current and legacy script deployment headers - #117
Merged
Merged
Conversation
Requested: make issue #107 ready to merge. Fix the proven mismatch between compile.js output and deployment header validation while retaining older pinned header support. Add tests against the real deployment manifest, legacy and malformed headers, and run the lightweight deployment suite in CI. All 15 deployment tests, type checking, and diff checks pass. Visitor-facing scripts are unchanged. Refs #107
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Claude review checkpointReviewed commit |
github-actions
Bot
added
the
change: routine
|
SDLC label: |
adriaandotcom
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #107.
The compiler emits
Privacy-first analytics, but deployment only acceptsPrivacy friendly analytics, so current v12 bundles fail validation before upload. Accept both exact header formats while retaining the existing date, hash, SRI, and version checks.Requested while making #107 ready to merge: fix the deployment blocker and add a regression against every JavaScript artifact in the real deployment manifest. Run the lightweight deployment tests alongside the existing build and unit checks in CI. Visitor-facing source and distributions are unchanged.
Security implications
Testing
dist/latest/latest.js; 14 tests pass and one fails.pnpm run typecheckandgit diff --checkpass on Node 24.18.0 / pnpm 11.17.0.pnpm run test:deployafter building and running the unit suite. No deployment or remote write is performed by these tests.deploy.mtsand the older deployment tests are kept out of scope; the new test block follows the configured style.Merge Danger
Door: two-way; a small validation change that can be reverted.
Blast Radius: deployment; both existing pinned scripts and current v12 outputs remain accepted.
Checklist