You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Remove retired custom deployment target from Caddy rollout - #119
Removes the retired custom deployment destination (the nginx server at app@external.simpleanalytics.com) from the deployment CLI, leaving cdn and caddy as the only targets. The Destination union, remoteTarget/RemoteTarget, uploadCustomFile, and the custom-server inspection and verification branches are deleted; readCustomFiles becomes readCaddyFiles against CADDY_HOST/CADDY_ROOT. addServerPair collapses into addCaddyPair, which always applies the caddy-ssi transform.
The destination prompt now offers CDN and Caddy with both selected by default, the proxy variant is offered when Caddy is selected, --caddy-only is unchanged, and the obsolete nginx reminder is replaced by a plain SRI documentation reminder. Caddy keeps consuming the existing dist/**/custom/ artifacts, so no generated script or SRI bytes change.
This targets PR #95 (caddy): merge this cleanup into #95 first, then merge #95 into main.
Changes:
Remove retired custom deployment target
Security implications
Has security impact - described as: changes production deployment routing by removing a retired destination and making Caddy a default target. Remote-path validation, shell quoting, Go-template escaping of proxy query values, --ignore-existing protection for immutable SRI artifacts, and post-upload content verification are all preserved.
Testing
node --test test/deploy.test.mts — 17/17 pass.
tsc (project tsconfig.json, --noEmit) — clean, no errors.
The reason will be displayed to describe this comment to others. Learn more.
README.md:41 still documents the deleted target: "Custom-domain reads and writes require SSH access to app@external.simpleanalytics.com", which no longer exists after this PR, so a deployer provisions access to the wrong host. Update that sentence to the remaining SSH target (user@esapp05.simpleanalytics.com, the CADDY_HOST in deploy.mts).
SDLC label: change: needs review because Changes production deployment routing by deleting a deployment destination and its upload/verification paths, and makes Caddy a default-selected target for customer-facing script releases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change: needs reviewChanges affecting security, data protection, or system stability.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #118
Removes the retired
customdeployment destination (the nginx server atapp@external.simpleanalytics.com) from the deployment CLI, leavingcdnandcaddyas the only targets. TheDestinationunion,remoteTarget/RemoteTarget,uploadCustomFile, and the custom-server inspection and verification branches are deleted;readCustomFilesbecomesreadCaddyFilesagainstCADDY_HOST/CADDY_ROOT.addServerPaircollapses intoaddCaddyPair, which always applies thecaddy-ssitransform.The destination prompt now offers CDN and Caddy with both selected by default, the proxy variant is offered when Caddy is selected,
--caddy-onlyis unchanged, and the obsolete nginx reminder is replaced by a plain SRI documentation reminder. Caddy keeps consuming the existingdist/**/custom/artifacts, so no generated script or SRI bytes change.This targets PR #95 (
caddy): merge this cleanup into #95 first, then merge #95 intomain.Changes:
Security implications
Has security impact - described as: changes production deployment routing by removing a retired destination and making Caddy a default target. Remote-path validation, shell quoting, Go-template escaping of proxy query values,
--ignore-existingprotection for immutable SRI artifacts, and post-upload content verification are all preserved.Testing
node --test test/deploy.test.mts— 17/17 pass.tsc(projecttsconfig.json,--noEmit) — clean, no errors.Checklist