Repository navigation
Fix cmd-click for auto events - #78
Merged
Merged
Conversation
adriaandotcom
marked this pull request as draft
March 3, 2026 10:41
added 2 commits
October 15, 2026 17:06
User request: recheck whether PR #78 remains relevant, fix the current issue, and add the commits to that PR. Current v12 still cancels modified clicks and redirects from tracking callbacks. Use listeners without replacing onclick and reuse the existing keepalive transport; retain event names and metadata. Rebuild current bundles while preserving existing SRI files. Validated with 41 unit tests, 12 deployment tests, typecheck, and 48 local click/transport scenarios.
User request: verify whether PR #78 is still relevant, fix it, and add commits to the existing PR. Resolve its stale source/distribution conflicts using the reviewed v12 implementation. Preserve the original PR history and include the freshly synchronized main branch through current v12. Use the exact locally validated tree from b0caa9a: browser-owned navigation and existing keepalive delivery, with pinned SRI bytes preserved. Local validation: build, 41 unit tests, 12 deployment tests, typecheck, formatting, 48 DOM scenarios, and real Chrome Cmd-click/plain/cancelled navigation with one event each.
Maimunar
approved these changes
Oct 15, 2026
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #45.
Automatic link tracking still cancelled Cmd/Ctrl/Shift/Alt-clicks and redirected the current page when tracking completed. Preserve native link behavior and site handlers while reusing v12's existing keepalive transport for event delivery.
Refreshed against current v12, which includes freshly synchronized main, and resolved the original PR's conflicts. Event names, metadata, collection settings, and one-event-per-click behavior remain unchanged. The third-argument callback remains callable for custom tracker integrations.
Security implications
Uses the existing tracking endpoint and payload; keepalive requests omit credentials. No extra collection is introduced.
Evidence
Testing
dist/v*files and SRI bytes are unchanged.Merge Danger
Door: two-way. Blast Radius: automatic link tracking.
Deploy the updated core tracker with the helper to enable keepalive delivery. Older/pinned core trackers that ignore the fourth event argument continue using image transport, so delivery during same-tab exits is best effort. The helper preserves native navigation with either version.
Checklist
adriaandotcom; GitHub rejects this because they are the PR author.