Skip to content

fix(desktop): let computer use type into date and time pickers - #9128

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/computer-use-date-time-text
Oct 16, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/computer-use-date-time-text

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • fix(desktop): tighten computer use input guards for text, tabs, menus and AX failures #9112's type_text gate didn't recognize AXDateTimeArea, the role an NSDatePicker field reports, so typing a time into Clock alarms or Calendar events was refused with "Keyboard focus is not in a text input"
  • Date and time pickers now count as text controls, like the legacy date/time field roles already did
  • The fixture gains a time picker whose action updates a Time: label, and live.py types an hour into it

Type of Change

  • Bug fix

Testing

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 16, 2026 8:43am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Adds AXDateTimeArea to the controls that accept text.

  • Computer use can type into date and time picker fields.

No actionable issues were found. macOS live tests were not run in this Linux environment.

Reviews (1) · Last reviewed commit: "fix(desktop): let computer use type into..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

Targeted Clock/Calendar benchmark (calendar-1_1..4, clock-1_1..4, one seed each):

Helper Passed Text-input refusals
Before #9112 7/8 0
#9112 (current staging) 4/8 10 in the full run
This PR 7/8 0

clock-1_3 fails on all three helpers (it's a multi-step alarm task, unrelated to this gate). The three episodes #9112 lost (calendar-1_3, clock-1_1, clock-1_4) pass again.

@waleedlatif1
waleedlatif1 merged commit 200b219 into staging Oct 16, 2026
44 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/computer-use-date-time-text branch October 16, 2026 17:59

This branch was previously deployed

1 inactive deployment
Preview — 2a83d1c2 Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant