Repository navigation
fix(desktop): let computer use type into date and time pickers - #9128
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryAdds
No actionable issues were found. macOS live tests were not run in this Linux environment. Reviews (1) · Last reviewed commit: "fix(desktop): let computer use type into..." · Reviewed by Greptile |
Collaborator
Author
|
Targeted Clock/Calendar benchmark (calendar-1_1..4, clock-1_1..4, one seed each):
clock-1_3 fails on all three helpers (it's a multi-step alarm task, unrelated to this gate). The three episodes #9112 lost (calendar-1_3, clock-1_1, clock-1_4) pass again. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type_textgate didn't recognizeAXDateTimeArea, the role an NSDatePicker field reports, so typing a time into Clock alarms or Calendar events was refused with "Keyboard focus is not in a text input"Time:label, andlive.pytypes an hour into itType of Change
Testing
AXDateTimeArealive.pyon macOS 26: fails on current staging's helper with the sameunsupported_actionrefusal, passes with this fixChecklist
test-auditauthoring gate)