Repository navigation
Conversation
Display actual CA warning metadata after native, offline, admin, and SSH identity credential handling, including both implicit SSH login paths. Sanitize terminal control data while preserving literal warning text. Keep warning writes nonfatal, including Unix stderr broken pipes, without changing process-wide signal behavior. Exercise real authority issuance, OIDC recovery, proxy login, offline operations, renewal, and rekey; keep the fixtures portable and race safe. This dependent change uses the new certificates warning contract. A published certificates release must be pinned before standalone builds; verify coordinated development with an external two-module workspace. See smallstep/certificates#381, smallstep/certificates#560
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name of feature:
Show CA certificate-validity warnings in the CLI.
Pain or issue this feature alleviates:
The CA can successfully issue a certificate with a shorter lifetime than requested because its issuing chain expires sooner. The CLI currently discards the warning explaining that reduction.
This change prints the CA's warnings on stderr after handling the returned credentials. It keeps certificate output separate and does not treat a failed warning write as an issuance failure.
Why is this important to the project (if not answered above):
A successful command should still tell users when they received a shorter-lived certificate. Displaying the warning makes the reason visible where they requested it, without requiring access to CA logs.
Is there documentation on how to use this feature? If so, where?
The CA and SSH command help and changelog describe when warnings appear. The companion certificates PR documents the server policy.
In what environments or workflows is this feature supported?
step ca certificate,sign,renew, andrekey, including offline X.509 operations and renewal daemons.In what environments or workflows is this feature explicitly NOT supported (if any)?
This does not add warnings to the ACME fallback, standalone
step certificate create/sign, or offline SSH operations that do not issue an X.509 identity. It does not change SSH validity or renewal scheduling.Warning writes tolerate unavailable stderr, including Unix broken pipes. Other CLI status messages retain their existing behavior.
Dependency and merge order:
This draft depends on smallstep/certificates#2820. The CLI still pins certificates
v0.30.2, so it cannot build independently until a release containing the new warning fields is available and pinned here. Verification currently uses a Go workspace containing both branches.Verification:
After checking both branches against current upstream, the full short suites passed in that workspace and both binaries built. Regression tests cover broken stderr and both implicit SSH login paths with real CA issuance. Focused race checks and lint also passed during feature verification.
Supporting links/other PRs/issues: