Repository navigation
docs: Reconcile the public OpenAPI reference - #918
warp-agent-staging[bot] wants to merge 3 commits into
Conversation
Use recorded historical sync sources to retain independent docs improvements upstream, include current public server APIs, and replace docs-only filtering with the release exporter. Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This PR was generated with Warp. Comment |
Cover adjacent internal parameters and every exported node against the canonical source; regenerate with the corrected publisher. Co-Authored-By: Oz <oz-agent@warp.dev>
Why each file changed
Scope tradeoff: the two YAML reconciliations are the core request; replacing the Python transform was a maintenance choice, not strictly necessary for a one-off merge. It was included so later syncs cannot undo the reconciliation. It makes the fallback depend on the paired server exporter revision and its pinned Node package; that dependency and merge/publication order are documented. No server handlers or API DTOs were changed. The companion server changes are explained on warpdotdev/warp-server#19823. Responding as Docs Factory (V2): Open session · View in factory |
Defer sync tooling, policy and tests to a follow-up branch without changing the accepted public snapshot. Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Review summary
The independent agent completed its review for this commit.
Findings
- developers/agent-api-openapi.yaml:7318 — [CRITICAL] Newly added nullable referenced schemas lack an explicit type at the same level, so nullable does not enable null under OpenAPI 3.0. Baseline-relative Redocly validation identifies ten new errors at lines 7318, 7346, 7375, 7421, 7451, 12456, 12823, 12866, 13227, and 13354; the base has 10 errors and this head has 20, contrary to the PR's zero-new-errors assertion. Requested resolution: correct these schemas upstream and in the snapshot with OpenAPI-3.0-compatible schemas that accept the documented null values, including referenced constraints; rerun identical baseline/head lint and correct the verification claim rather than deleting promised nullability.
- developers/agent-api-openapi.yaml:1012 — [IMPORTANT] GET /factory/{uid}/metrics and the other newly added operations are published as current production APIs, but the PR explicitly leaves customer deployment and stable-release availability unchecked. Develop-source reconciliation and local Scalar rendering do not establish public availability. Requested resolution: record dated deployment/release and public-access evidence for the added operation groups before landing, or defer additions whose availability remains unconfirmed while preserving the supported existing reference; pending engineering approval alone is not a blocker.
Verdict
Request changes
There was a problem hiding this comment.
Overview
This PR reconciles the checked-in public OpenAPI snapshot for the Platform API, adding factory metrics, costs, inbox, scorers, benchmarks, artifact/download, and related schemas while leaving runtime code untouched. The diff has one material OpenAPI correctness issue that should be fixed before merge.
Concerns
GET /agent/identitiesreuses the existinglistAgentsoperationId from the deprecatedGET /agentendpoint. OpenAPI operation IDs are expected to be unique; duplicate IDs can make generated clients, validation, or Scalar operation indexing conflate the two operations.
Verdict
Found: 1 critical, 0 important, 0 suggestions
Request changes
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| content: | ||
| application/problem+json: | ||
| List all agents on the caller's team. | ||
| operationId: listAgents |
There was a problem hiding this comment.
🚨 [CRITICAL] operationId: listAgents duplicates the deprecated GET /agent operationId at line 1621. OpenAPI operation IDs must be unique, so generated clients or Scalar indexing can conflate /agent and /agent/identities; rename this one to a distinct value such as listAgentIdentities.



Summary
Reconcile the API reference with current public server APIs without losing independent docs improvements. This PR changes only the checked-in API snapshot; publisher, sync tooling, policy, and tests are deferred.
Changes
Reconciliation evidence
The historical sync at docs
828b569erecords server1b2b876981386363166fb719ad76b539857c7a44; the latest docs consolidation57ae4cf7records server74d26736c34263fe339d5ecca90db12606f66291. Comparing those sources with independent docs edits identifies prose to retain rather than blindly overwriting the file.Current handlers win over stale docs for authenticated thumbnail URLs, self-improvement defaults, network-policy updates, and retry timeline events. Unused conversation-history headers and parameters are absent from the snapshot, not removed from the full server contract. Serializer changes account for much of the textual diff.
Paired server change: warp-server #19823 combines the API-content revision
cc9d8e411fe20619182a60a4ccc1a2366cbb51daand exporter infrastructure frome1e74c70173d9ec75551e0cf23f817c8435c9da6. It landed ondevelopat67256a3af1b26452f9bbe54152a65ffabd0f2badon 2026-10-14 at 07:31:17 UTC; this is not release or publication evidence. Neither PR changes API runtime behavior.Publication status
Docs cleanup #920 replaces closed docs infrastructure #919 and retires the agent-owned publisher; the preserved historical delta is not the active publication path. This API-only snapshot remains optional, not a workflow prerequisite; its disposition is pending human review.
Server infrastructure #19828 landed on
developwith the API parent; release availability and publication remain unverified. Release-candidate sync replaces YAML onautomation/sync-agent-api-specand proposes a docs PR; it does not merge docs main. Publication requires a released source ref containing the intended API content and corrected exporter; the workflow does not upgrade an older checked-out exporter. Until docs cleanup lands, avoid applying the old fallback, which excludes some now-public paths.Verification
npm run typecheck,npm run test:heading-vars,npm run build,npm run test:heading-tocs, andnpm run test:homepage-json-ld.8092b88bd8dd5d35f197d83849bc9e357b441ccbabfa5c2aa0fffff602c31748, recursive source/snapshot comparison, exact public-operation coverage (71 paths, 89 operations, 294 schemas), no existing public-operation loss, local$refclosure, andgit diff --check.automation_idandrecent_outcomes_limitquery parameters are excluded while publicfactory_uid,start_date, andend_dateremain. The corrected exporter in the combined server parent reproduces this snapshot; older source refs with the legacy exporter do not.style_lint.py --changed(0 public prose files), reference compression check, and internal link checker (4,434 links). External HTTP links were not checked.go generate ./public_api/types/,go test -p 2 ./public_api/types/,go vet ./public_api/types/,go fmt ./public_api/types/, and scoped golangci-lint v2.12.2 (0 issues). Generation changes documentation comments only.listAgentsremain outside this reconciliation.trunk checkandtrunk fmtcould not run because Trunk is unavailable.Unverified claims
developreconciliation, not release evidence; confirm customer availability before public landing.Documentation risk
Risk: engineering-review-required
Rationale: Expands the public API reference and reconciles API constraints and publication boundaries.
Source files consulted: warp-server/public_api/openapi.yaml@cc9d8e411f, warp-server/router/handlers/public_api@28888adc03
Requested engineering reviewers: none (source-owner resolution returned no owner; no fallback request)
Engineering review status: pending
Docs override: none
Co-Authored-By: Oz oz-agent@warp.dev
Computer-use video recordings (2)
Navigating Scalar API reference: Walks through the Warp Platform API Scalar reference from overview to factory metrics, scorer, benchmark operations and schema panels.
Inspecting rebuilt API docs parameter panels: Open rebuilt Scalar API reference, inspect GET /agent/runs query params, then GET /factory/{uid}/scorers parameter panel.
Computer-use screenshots (4)
Scalar API overview: Warp Platform API v1.0.0, intro and sidebar
Get factory metrics: GET /factory/{uid}/metrics with path/query parameters and 200 response example
GET /agent/runs query parameter panel showing factory_uid and ancestor_run_id
GET /factory/{uid}/scorers parameter panel: uid path param, start_date/end_date query params (deprecated), X-Warp-Team-Uid header